[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Python plugin update



> > I'm attaching a drop-in upgrade to the python plugin. Here is
> > the change list:
> 
> A few days ago I checked into CVS the fixes/changes made by Marko
> Kreen and Gustavo J. A. M. Carneiro. Now, who wants to resolve the
> differences?
> 
> http://cvs.sourceforge.net/viewcvs.py/xchat/xchat2/plugins/python/

Ok, I've had a look, and the changes introduced were mainly
related to the reentrancy bug, and code style changes. The
reentrancy fix is already included in the update. The style
changes were dropped. Besides these, I've merged the
lock-unlock reordering, which seems like a good idea, and
wasn't being done yet, and the retobj check in Plugin_Delete.

Notice that the patched plugin introduced a bug in BEGIN_PLUGIN,
since an xchat call is done without holding the lock.

I belive you can safely drop the attached file in. It will be a
pleasure to discuss this if someone disagrees.

Thanks!

-- 
Gustavo Niemeyer
http://niemeyer.net

python.c.bz2