[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Python plugin API locking (patch)



On Sat, 4 Oct 2003 01:18:33 +0300
Marko Kreen <marko@l-t.ee> wrote:

> > This patch should protect all plugin API functions with a global
> > recursive mutex.
>
> Thats a cool patch, but it seems its not enough...
>
> You protect plugins from each other, thats cool, but at the
> moment plugin can run gtk signal loop, its not enough: now also
> xchat C code should go through locks, that means that locks
> should be in xchat core code.  Thats what made me so worried...

Strictly speaking, plugins shouldn't access xchat's gtk main loop.
You shouldn't use any of xchat's libraries, open/link your own. The
practicalities of this might be problem though.

When you come to a consensus on which patches should be applied
to python.c, let me know :)

P.S Please check the HACKING file for coding style if you want to patch
plugin.c (I don't care about python.c coding style).

-- 
Peter Zelezny.
--
XChat-discuss: mailing list for XChat users
Archive:       http://mail.nl.linux.org/xchat-discuss/