Re: dcc server patch for 2.0.1

[Richard Fuchs <dfx@gmx.at>]

Peter Zelezny wrote:
> On Sat, 26 Apr 2003 14:42:56 +0200
> Richard Fuchs <dfx@gmx.at> wrote:
> 
> 
>>>Do you want to merge this into the main dist.? If so, I can see a
>>>couple small errors, but nothing too major.
>>>
>>
>>sure, why not, if it's not too hackish for you ;)
> 
> 
> Maybe a little :) It'd be nice if it didn't replicate code so much, like
> when it creates the filename string.

well i wanted to touch existing code as little as possible, but if it's 
ok with you, i can make it "nicer".

> 
> Some problems:
> 
> * change current_tab to current_sess (there might not be any
>    tabs).
> * dcc->destfile is g_free'ed, so it must be g_malloc'ed (not malloc'ed).
> * snprintf(msg, sizeof(msg) - 1, N_("Could not open dccserver listening port on port %u: %s\n"),
>    This should be _("Could not...."); (and other places where N_() is used).
>    You could make your life easier here by using PrintTextf() too.
> * The 3rd arg of accept() should be (socklen_t *)
> * if (errno != EWOULDBLOCK && errno != EAGAIN && errno != EINTR)
>    Does EINTR ever happen? There's a macro called would_block_again()
>    you can use here to make it win32 compat (from inet.h).
> * change close() to closesocket()
> 
> 

some of these are there because it's just a quick port from 1.8 to 2.0 
code. i'll get it fixed and post another ver.

greets
richard

--
XChat-discuss: mailing list for XChat users
Archive:       http://mail.nl.linux.org/xchat-discuss/