Re: [PATCH] chanlist treeview

[Peter Zelezny <zed@xchat.org>]

On Tue, 8 Apr 2003 00:00:08 +1000
Vincent Ho <loki@internode.on.net> wrote:

> Hi all,
> 
> Here's the (hopefully final) channel list treeview patch.  Sorry for the
> delay, real-world stuff intervened.
>
> I went ahead and just finished/cleaned up the version which uses glib's
> binary trees.  I think the simpler code is probably worth any
> performance loss.  No real functionality changes; I toyed with the idea
> of trying to improve the GUI, but couldn't really come up with anything
> satisfactory.  I leave that as an academic exercise for the reader :)
>
> Patch is attached.

There's some kind of strange bug. When I try to resize column 0 while it's
downloading, it disappears. It's probably changed to 0 size, and I can't
get it back. Can you reproduce this?

I've compared the current gtkclist and your patch, and the results arn't
all that bright. It's a good 10x slower. I'd imagine this'd make it close
to unusable on a ~300mhz machine (does someone want to try that?).

All your code is probably good, but it's invoking something bad in gtk. I
might try recompiling a profilable glib/gtk to see what exactly is causing
it.

PS. I found out that GTK_TREE_VIEW_COLUMN_AUTOSIZE made the Userlist really
slow in xchat, but you don't seem to be using that.


-- 
Peter Zelezny.
--
XChat-discuss: mailing list for XChat users
Archive:       http://mail.nl.linux.org/xchat-discuss/