Re: 1.9.4 file move on complete patch (revision 3)

[Chris Morgan <cmorgan@alum.wpi.edu>]

Is this patch all set for 1.9.5(2.0pre1)?

Thanks,
Chris

On Wednesday 13 November 2002 11:35 pm, Chris Morgan wrote:
> On Friday 08 November 2002 09:45 pm, Peter Zelezny wrote:
> > On Fri, 8 Nov 2002 10:39:48 -0500
> >
> > <chrismorgan@rcn.com> wrote:
> > > Peter, I still haven't heard anything back about this patch and what I
> > > can do to get it into shape for 1.9.5.  I do know of a few people other
> > > than myself that are using it successfully and there appears to be a
> > > demand for it.
> >
> > * Using that same coding style as most of xchat. Like:
> >
> > void
> > download_move_to_completed_dir (char *dcc_dir, char *dcc_completed_dir,
> > char *output_name) {
>
> Fixed this case, not really sure if you are referring to other things, the
> tabbing and braces styles look the same to me, if there is anything else
> you want fixed just say so.
>
> > * I think we should keep the current behaviour as default.
> >   (Perhaps leave prefs.dcc_Completed_dir blank, and no moving).
>
> Default is now the same directory as the dcc so the moving is off by
> default.
>
> > * Use "| OFLAGS" on all unix level open()'s. No need for the #ifdef
> > WIN32.
>
> Fixed.
>
> > * Xchat has a dcc permissions setting. Will this work after the file
> >   has been moved?
>
> Fixed, we now use prefs.dccpermissions as the permissions on the
> destination file in the case where rename() fails.
>
> Anything else that needs to be addressed?  Attached is a patch against
> 1.9.4, I'd like to get this patch into 1.9.5 if at all possible.
>
> Thanks,
> Chris

--
XChat-discuss: mailing list for XChat users
Archive:       http://mail.nl.linux.org/xchat-discuss/