[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: problem with channel modes and menubar + a patch



Actually, it was my problem from the very beginning.
I had did /mode +s #channel ... :(

James: I turned the program in exactly 30 seconds before the deadline. I so
rock. :P

-Josh
----- Original Message -----
From: "Peter Zelezny" <zed@linux.com>
To: <xchat-discuss@nl.linux.org>
Sent: Friday, November 08, 2002 7:13 PM
Subject: Re: problem with channel modes and menubar + a patch


> On Fri, 8 Nov 2002 20:35:06 -0600
> "James D. Taylor" <jtaylor5@bayou.uh.edu> wrote:
>
> > > Ummmm.. Anything sent to irc_raw already has \r\n at the end.
> > > What's this for?
> > Ahh, excellent.  We could simplify everything that calls p_raw, or
> > we could simplify irc_raw.   It's a matter of interface convention.
> > So if we say that p_raw shouldn't be called with \r\n; then a lot of
> > specialized code goes away, and irc_raw stays the same.
> >
> > To answer your question, the patch was to keep \r\n\r\n from happening.
> > I'm not sure how other servers would have handled this, but I know it
> > shouldn't have been happening.
>
> Well, I lie actually, I was thinking of tcp_send(). Since p_raw adds \r\n,
> we may aswell remove it from all the calls to p_raw. Cmd_quote has a
string
> without \r\n, so I guess it's best to leave the sprintf in p_raw and
remove
> the \r\n's elsewhere. I'll do it in a sec...
>
> --
> Peter Zelezny.
> --
> XChat-discuss: mailing list for XChat users
> Archive:       http://mail.nl.linux.org/xchat-discuss/

--
XChat-discuss: mailing list for XChat users
Archive:       http://mail.nl.linux.org/xchat-discuss/