Re: 1.9.4 file move on complete patch

[Peter Zelezny <zed@linux.com>]

On Fri, 8 Nov 2002 10:39:48 -0500
<chrismorgan@rcn.com> wrote:

> Peter, I still haven't heard anything back about this patch and what I can
> do to get it into shape for 1.9.5.  I do know of a few people other than
> myself that are using it successfully and there appears to be a demand for
> it.

* Using that same coding style as most of xchat. Like:

void
download_move_to_completed_dir (char *dcc_dir, char *dcc_completed_dir, char *output_name)
{

* I think we should keep the current behaviour as default.
  (Perhaps leave prefs.dcc_Completed_dir blank, and no moving).

* Use "| OFLAGS" on all unix level open()'s. No need for the #ifdef WIN32.

* Xchat has a dcc permissions setting. Will this work after the file
  has been moved?

-- 
Peter Zelezny.
--
XChat-discuss: mailing list for XChat users
Archive:       http://mail.nl.linux.org/xchat-discuss/