Re: dcc throttle patch for 1.9.4

[Richard Fuchs <dfx@gmx.at>]

On Fri, 8 Nov 2002 23:40:08 +1100
Peter Zelezny <zed@linux.com> wrote:

> - if (tim - dcc->lasttime > prefs.dccstalltimeout)
> + if (!dcc->throttled
> +     && tim - dcc->lasttime > prefs.dccstalltimeout)
> 	EMIT_SIGNAL (XP_TE_DCCSTALL, dcc->serv->fro
> 
> does this mean throttled transfers can't stall?

Yes. More specifically, it means that if the dcc doesn't send (or
receive) because it is throttled, it won't be killed by the stall
timeout. The reason for this is that, for example, if you have a dcc
going at a high speed and then enable a cps throttle, it will take some
time until the cps drops to the specified amout. During this time, the
dcc isn't stalled, but throttled, and so shouldn't be timed out (even
though it's possible that the transfer will be killed by the peer). I'm
not sure if the above code has the desired effect or if it has any side
effects, but I haven't got any bug reports about it.

Richard
--
XChat-discuss: mailing list for XChat users
Archive:       http://mail.nl.linux.org/xchat-discuss/