[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bugfixes




Hi,

I fixed a typo in HTTPHandler.cc ("Content-Type" was spelled "Content-type")
that resulted in an empty contentmessage being sent to the FilterStack.
HTTP urls now also work for me.

Do the RFCs demand that the headers have a fixed case, or would it be
better to do a case-insensitive search for the header lines?

While hunting down this bug, I noted a 'FIXME:' related to fixed-size
buffers in the construction of the 'GET' command (in
HTTPRequest10.cc). As an example I changed that particular one to use
strstreams instead. If you've never used strstreams you might want to
take a look at it.

Two more comments:

  - On my Apache server, when I make a bad request I get back
    a document that is html, but doesn't have any Content-Type header
    (no header at all, actually). HTTPResponse.cc does not insert a
    default one either, and that makes FilterStack crash. Should we
    use a default setting here? 

  - Opening a url of the form 'http://myhost.domain' leads to a request
    'GET  HTTP/1.0' which is invalid. I was not sure what is the best
    place to turn this empty string into a single slash, so I left this
    bug unfixed.

Kasper