[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: additional comments to my proxy changes



Hello Hakan,

[HTTPHandler.cc/GetObject]
> When you search for already open connections:
>   if( (cindex = FindAliveFD(url->host, url->port)) != -1) {
> you search for connections to the host itselfe, not the proxy, this should
> be:
> 
>   if( (cindex = FindAliveFD(proxy_url->host, proxy_url->port)) != -1) {
> 
> Or have I mussunderstood something?
ups, yes thats a mistake. thanks, i correct this.

>  conns[cindex].req = new HTTPRequest10(mgroup,url->host,url->port,url->location);
> If you instead do:
>  conns[cindex].req = new HTTPRequest10(mgroup,url->host,url->port,s_url);
> 
> This way the location in HTTPRequest10 will be "http://host/location".
> This will also make HTTPRequest10 and HTTPHandler completly protocoll
> independent!
> 
> What do you say, is this a good way?

I think thats a good way - we can so provide a more protocol independent
proxy. I implement this.

cu, 
Ueli (urutishauser@bigfoot.com)