[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/5] mm improvements
Andrew Morton wrote:
>Nick Piggin <piggin@cyberone.com.au> wrote:
>
>>+ if (zone->nr_active >= zone->nr_inactive*4)
>> + /* ratio will be >= 2 */
>> + imbalance = 8*nr_pages;
>> + else if (zone->nr_active >= zone->nr_inactive*2)
>> + /* 1 < ratio < 2 */
>> + imbalance = 4*nr_pages*zone->nr_active / (zone->nr_inactive*2);
>>
>
>This can cause a divide-by-zero, yes?
>
>
Yes. Sorry. I guess just adding 1 to the divisor should be fine.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>