Re: TLB flush optimization on s/390.

["David S. Miller" <davem@redhat.com>]

On Thu, 9 Oct 2003 14:38:45 +0200
Martin Schwidefsky <schwidefsky@de.ibm.com> wrote:

> Ok, renamed three of the new functions. Patch @EOM.

I'm fine with everything except this:

> -static int
> -copy_one_pte(struct mm_struct *mm, pte_t *src, pte_t *dst,
> -		struct pte_chain **pte_chainp)
> +static inline int
> +copy_one_pte(struct vm_area_struct *vma, unsigned long old_addr,
> +	     pte_t *src, pte_t *dst, struct pte_chain **pte_chainp)

There is no way you should start inling this.

At best, you should suggest such a change seperately from these API
changes you are proposing.  When you mix multiple changes together you
risk the whole patch being rejected, so please avoid this in the
future.

Thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>