[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] fix split_vma vs. invalidate_mmap_range_list race



On Fri, 3 Oct 2003 23:58:04 -0400 (EDT)
"V. Rajesh" <vrajesh@eecs.umich.edu> wrote:

> 4) In arch/sparc64, vm_end is updated without holding i_shared_sem.
>    Check make_hugetlb_page_present.  I hope that is fine, but 
>    I am not sure. 

You can ignore this case for now if you want, the sparc64 hugetlb code
is in a state of disrepair.  I plan to nearly rewrite it over the
weekend so it's more uptodate and in line with the current x86 and
ia64 hugetlb support code.

I think you are right about these races, they exist and they are
real.  Someone should just make sure you haven't added any deadlock
or semaphore taking with spinlocks held in higher level callers.
I don't think your patch does, but it's something to audit.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>