Re: [PATCH] remove __pte_offset

["Martin J. Bligh" <mbligh@aracnet.com>]

> Sorry, I was only thinking about the type of the index initially, not 
> the type of the data being passed into the macro.  Yes, the macro does 
> take an address, so it should be more like addr_to_pfn_index or somesuch.  
> I still think pte_index isn't clear, though.

It's not a pfn index though - pfns are physical, this is virtual still.

It's the index into the pte page ... vaddr_to_pte_page_index I guess,
but pte_index seems easier ;-)

> akpm
> pfn = pageframe number.

Right, yes ... but that's still really just a physical address (>> PAGE_SHIFT).
I was trying to emphasize phys vs virt. But I was being needlessly obtuse ;-) 

M.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>