Re: [PATCH][RFT](2) minimal rmap for 2.5 - akpm tested

[Andrew Morton <akpm@zip.com.au>]

Linus Torvalds wrote:
> 
> On Fri, 5 Jul 2002, Andrew Morton wrote:
> >
> > The box died, but not due to rmap.  We have a lock ranking
> > bug:
> >
> >         do_exit
> >         ->mmput
> >           ->exit_mmap                           page_table_lock
> >             ->removed_shared_vm_struct
> >               ->lock_vma_mappings               i_shared_lock
> 
> I _think_ we should just move the remove_shared_vm_struct() down into the
> case where we're closing the mapping, ie something like the appended.
> 
> That way we _only_ do the actual page table stuff under the page table
> lock, and do all the generic VM/FS stuff outside the lock.
> 
> Comments?

That is basically what do_munmap() does.  But I'm quite unfamiliar
with the locking in there.

-
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/