[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: page-flags.h

On Tue, May 14, 2002 at 01:25:43PM -0700, Andrew Morton wrote:
> Erik van Konijnenburg wrote:
> > 
> > ...
> > For pagemap.h, just three functions are responsible for
> > an 82Kb callgraph: page_cache_alloc, add_to_page_cache,
> > wait_on_page_locked.
> 
> inlines in headers are just a pita.  I know it gets people
> all excited but I'd say: make 'em macros.
> 
> ___add_to_page_cache() can be just uninlined.  I intend
> to gang-add pages into the cache and LRU anyway, so that
> function should become for "occasional use only" anyway.

I'm all for it.  I nfact I have a patch to rename it to link_to_page_cache()
and make it an uninline FASTCALL pending, waiting for the buffer_head.h
patch going to Linus first.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/