Re: [PATCH] rmap 13a

[Roman Zippel <zippel@linux-m68k.org>]

Hi,

William Lee Irwin III wrote:

> A:
> static inline void *page_address(struct page *page)
> {
>         return __va((page - mem_map) << PAGE_SHIFT);
> }

This is very broken.

> If table lookup is wanted, I feel that should also be a generic option.
> There is nothing inherently architecture-specific about using a table-
> driven method of calculating page_address().

Archs already do the kaddr->node lookup. Archs setup the virtual mapping
and the pgdat nodes, they know best how they are layed out. Why do you
want to generalize this?

bye, Roman
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/