Re: [PATCH] rmap 13a

[Christoph Hellwig <hch@infradead.org>]

On Mon, May 06, 2002 at 11:17:26PM -0300, Rik van Riel wrote:
> rmap 13a:
>   - NUMA changes for page_address                         (Samuel Ortiz)

I don't think the changes makes sense.  If calculating page_address is
complicated and slow enough to place it out-of-lin using page->virtual
is much better.

I'd suggest backing this patch out and instead always maintain page->virtual
for discontigmem.  While at this as a little cleanup you might want to
define WANT_PAGE_VIRTUAL based on CONFIG_HIGHMEM || CONFIG_DISCONTIGMEM
at the top of mm.h instead of cluttering it up.

	Christoph

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/