[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: page-flags.h



On Fri, May 03, 2002 at 04:06:05PM -0700, Andrew Morton wrote:
 > Part of my uncertainty here is that we just don't seem to
 > have a "plan".  Is the objective to completely flatten
 > the include heirarchy, no nested includes, and make all
 > .c files include all headers to which they (and their included
 > headers) refer?
 > 
 > That's pretty aggressive, but I think it's the only sane
 > objective.

<linux/fs.h>, <linux/mm.h>, <linux/sched.h>, <linux/pagemap.h>
are usually the main culprits. Each of these suckers pulls in
dozens and dozens of includes.

So every time someone wants for eg, something trivial like
jiffies, they end up pulling in crap like <asm/mmx.h>
It's hurrendous how much stuff we have in some of the above
mentioned files which probably deserves their own files.

Updated graphs of these dependancies just went up to
ftp://ftp.kernel.org/pub/linux/kernel/people/davej/misc/graphs/

(old versions are in the parent dir before/after the last crapectomy)

    Dave.

-- 
| Dave Jones.        http://www.codemonkey.org.uk
| SuSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/