Re: page-flags.h

[Christoph Hellwig <hch@infradead.org>]

On Wed, May 01, 2002 at 07:27:37PM +0200, Dave Jones wrote:
> A new header file appeared in 2.5.12, include/linux/page-flags.h
> Currently, there are many places that need this, but instead of
> including it, they are including <linux/mm.h> which in turn sucks
> in zillions of other files.
> 
> According to a comment in mm.h, there are 119 places that need
> fixing here.
> 
> Method:
> o  Remove the #include <linux/page-flags.h> from mm.h
> o  Compile, and see what breaks.
> o  Add #include <linux/page-flags.h> to file compilation died on.
> o  Try removing the <linux/mm.h> include also, but this may not
>    be possible in all circumstances.

This step is wasted work - it will NEVER compile.  Rationale:
the page flags operate on page->flags and without having the definition
of struct page from mm.h this won't do.

The better idea is IMHO to replace page-flags.h by page.h that also
contains the definition of struct page.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/