[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC] Page table sharing
- To: Linus Torvalds <torvalds@transmeta.com>,Rik van Riel <riel@conectiva.com.br>
- Subject: Re: [RFC] Page table sharing
- From: Daniel Phillips <phillips@bonn-fries.net>
- Date: Fri, 22 Feb 2002 07:32:31 +0100
- Cc: Hugh Dickins <hugh@veritas.com>, <dmccr@us.ibm.com>,Kernel Mailing List <linux-kernel@vger.kernel.org>,<linux-mm@kvack.org>, Robert Love <rml@tech9.net>,<mingo@redhat.com>, Andrew Morton <akpm@zip.com.au>,<manfred@colorfullife.com>, <wli@holomorphy.com>
- Fake-Sender: owner-linux-mm@kvack.org
- In-Reply-To: <E16e8Gf-0005HN-00@starship.berlin>
- Original-Recipient: rfc822;linux-mm-archive@humbolt.geo.uu.nl
- References: <Pine.LNX.4.33.0202181758260.24597-100000@home.transmeta.com> <E16e8Gf-0005HN-00@starship.berlin>
- Sender: Rik van Riel <riel@nl.linux.org>
The following gross mistake was noticed promptly by Rik van Riel:
spin_lock(&page_table_share_lock);
- if (page_count(virt_to_page(pte)) == 1) {
+ if (put_page_testzero(virt_to_page(pte))) {
pmd_clear(dir);
pte_free_slow(pte);
}
spin_unlock(&page_table_share_lock);
However, oddly enough, that's not the memory leak.
--
Daniel
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/