Re: [PATCH *] rmap VM, version 12

[Rik van Riel <riel@conectiva.com.br>]

On Wed, 23 Jan 2002, David S. Miller wrote:

>    Actually, this is just using the pte_free_fast() and
>    {get,free}_pgd_fast() functions on non-pae machines.
>
> Rofl, you can't just do that.  The page tables cache caches the kernel
> mappings and if you don't update them properly on SMP you die.

Umm, this list just contains _freed_ page tables without
any mappings, right ?

If there is some specific magic I'm missing, could you
please point me to the code I'm overlooking ? ;)

> I am seeing reports of SMP failing with rmap12 but not previous
> patches.  You need to revert this I think.

Actually, the cause for Badari's bugreport is much more
stupid.  If it wasn't so stupid I bet I'd have found it
earlier...

regards,

Rik
-- 
"Linux holds advantages over the single-vendor commercial OS"
    -- Microsoft's "Competing with Linux" document

http://www.surriel.com/		http://distro.conectiva.com/


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/