Re: 2.4.14 + Bug in swap_out.

[ebiederm@xmission.com (Eric W. Biederman)]

Rik van Riel <riel@conectiva.com.br> writes:

> On 20 Nov 2001, Eric W. Biederman wrote:
> > "David S. Miller" <davem@redhat.com> writes:
> >
> > > I do not agree with your analysis.
> >
> > Neither do I now but not for your reasons :)
> >
> > I looked again we are o.k. but just barely.  mmput explicitly checks
> > to see if it is freeing the swap_mm, and fixes if we are.  It is a
> > nasty interplay with the swap_mm global, but the code is correct.
> 
> To be honest I don't see the reason for this subtle
> playing with swap_mm in mmput(), since the refcounting
> should mean we're safe.

We only hold a ref count for the duration of swap_out_mm.
Not for the duration of the value in swap_mm.

Eric
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/