[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Reap dead swap cache earlier v2

To: John Stoffel <stoffel@casc.com>
Subject: Re: [PATCH] Reap dead swap cache earlier v2
From: Hugh Dickins <hugh@veritas.com>
Date: Thu, 7 Jun 2001 16:44:06 +0100 (BST)
cc: Marcelo Tosatti <marcelo@conectiva.com.br>,Linus Torvalds <torvalds@transmeta.com>,lkml <linux-kernel@vger.kernel.org>, linux-mm@kvack.org
In-Reply-To: <15135.37871.373389.465893@gargle.gargle.HOWL>
Sender: owner-linux-mm@kvack.org

On Thu, 7 Jun 2001, John Stoffel wrote:
> Shouldn't the "swap_count(page) == 1" check be earlier in the if
> statement, so we can fall through more quickly if there is no work to
> be done?  A small optimization, but putting the common cases first
> will help.

I don't think so: the out-of-line swap_count() function is considerably
more complicated than the macros and inline functions tested before it.

Hugh

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/

References:
- Re: [PATCH] Reap dead swap cache earlier v2
  - From: John Stoffel <stoffel@casc.com>

Prev by Date: Re: Break 2.4 VM in five easy steps
Next by Date: Re: [PATCH] reapswap for 2.4.5-ac10
Prev by thread: Re: [PATCH] Reap dead swap cache earlier v2
Next by thread: Re: [PATCH] Reap dead swap cache earlier v2
Index(es):
- Date
- Thread