[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Prevent OOM from killing init

To: Eli Carter <eli.carter@inet.com>
Subject: Re: [PATCH] Prevent OOM from killing init
From: "Patrick O'Rourke" <orourke@missioncriticallinux.com>
Date: Wed, 21 Mar 2001 18:40:50 -0500
CC: linux-mm@kvack.org, linux-kernel@vger.kernel.org
References: <3AB9313C.1020909@missioncriticallinux.com> <3AB9352A.71E42C38@inet.com>
Sender: owner-linux-mm@kvack.org
User-Agent: Mozilla/5.0 (X11; U; Linux 2.4.3-pre6 i686; en-US; 0.8) Gecko/20010218

Eli Carter wrote:

> Having not looked at the code... Why not "if( p->pid > 1 )"?  (Or can
> p->pid can be negative?!, um, typecast to unsigned...)

I simply mirrored the check done in do_exit():

	if (tsk->pid == 1)
		panic("Attempted to kill init!");

Since PID_MAX is 32768 I do not believe pids can be negative.

I suppose one could make an argument for skipping "daemons", i.e.
pids below 300 (see the get_pid() function in kernel/fork.c), but
I think that is a larger issue.

Pat

-- 
Patrick O'Rourke
978.606.0236
orourke@missioncriticallinux.com

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/

References:
- [PATCH] Prevent OOM from killing init
  - From: "Patrick O'Rourke" <orourke@missioncriticallinux.com>
- Re: [PATCH] Prevent OOM from killing init
  - From: Eli Carter <eli.carter@inet.com>

Prev by Date: Re: [PATCH] Prevent OOM from killing init
Next by Date: Re: [PATCH] Prevent OOM from killing init
Prev by thread: Re: [PATCH] Prevent OOM from killing init
Next by thread: Re: [PATCH] Prevent OOM from killing init
Index(es):
- Date
- Thread