Re: [PATCH] ac7: page_launder() & refill_inactive() changes

[Benjamin Redelings I <bredelin@ucla.edu>]

Content-Type: text/plain; charset=big5
Content-Transfer-Encoding: 7bit

Hi Marcelo:
	In the patch you provided, have you perhaps reverse the sense of this
test:

+                       if (try_to_free_buffers(page, wait))
+                               flushed_pages++;

Should this have a NOT (!) instead?

+                       if (!try_to_free_buffers(page, wait))
+                               flushed_pages++;

BTW, has anyone done any MM benchmarks of the 2.4.2-ac? against Linus's
tree?

-BenRI
-- 
"...assisted of course by pride, for we teach them to describe the
 Creeping Death, as Good Sense, or Maturity, or Experience." 
- "The Screwtape Letters"
Benjamin Redelings I      <><     http://www.bol.ucla.edu/~bredelin/
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/