[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] guard mm->rss with page_table_lock (241p11)

To: george anzinger <george@mvista.com>
Subject: Re: [PATCH] guard mm->rss with page_table_lock (241p11)
From: Marcelo Tosatti <marcelo@conectiva.com.br>
Date: Tue, 13 Feb 2001 00:05:50 -0200 (BRST)
cc: Rasmus Andersen <rasmus@jaquet.dk>, Rik van Riel <riel@conectiva.com.br>, torvalds@transmeta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org
In-Reply-To: <3A88A6ED.6B51BCA9@mvista.com>
Sender: owner-linux-mm@kvack.org

On Mon, 12 Feb 2001, george anzinger wrote:

> Excuse me if I am off base here, but wouldn't an atomic operation be
> better here.  There are atomic inc/dec and add/sub macros for this.  It
> just seems that that is all that is needed here (from inspection of the
> patch).

Most functions which touch mm->rss already hold mm->page_table_lock (also
this functions are called more often and they use more CPU).

Making those functions use an atomic instruction just to optimize the
functions which do not lock mm->page_table_lock is not a good tradeoff.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/

References:
- Re: [PATCH] guard mm->rss with page_table_lock (241p11)
  - From: george anzinger <george@mvista.com>

Prev by Date: Re: [PATCH] guard mm->rss with page_table_lock (241p11)
Next by Date: Re: [PATCH] guard mm->rss with page_table_lock (241p11)
Prev by thread: Re: [PATCH] guard mm->rss with page_table_lock (241p11)
Next by thread: Re: [PATCH] guard mm->rss with page_table_lock (241p11)
Index(es):
- Date
- Thread