[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] drop-behind fix for generic_file_write

To: Rik van Riel <riel@conectiva.com.br>, Linus Torvalds <torvalds@transmeta.com>
Subject: Re: [PATCH] drop-behind fix for generic_file_write
From: Daniel Phillips <phillips@innominate.de>
Date: Wed, 3 Jan 2001 16:21:17 +0100
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, linux-kernel@vger.kernel.org, linux-mm@kvack.org
In-Reply-To: <Pine.LNX.4.21.0101031256040.1403-100000@duckman.distro.conectiva>
References: <Pine.LNX.4.21.0101031256040.1403-100000@duckman.distro.conectiva>
Sender: owner-linux-mm@kvack.org

On Wed, 03 Jan 2001, Rik van Riel wrote:
> Hi Linus, Alan,
> 
> the following (trivial) patch fixes drop-behind behaviour
> in generic_file_write to only drop fully written pages.
> 
> This increases performance in dbench by about 8% (as
> measured by Daniel Phillips) and should get rid of the
> logfile bottleneck Ingo Molnar found with the drop-behind
> call in generic_file_write in TUX tests.

Rik, I detected the speedup in -pre5 but it disappeared in -pre7 (which
turned in a faster performance than pre5 or 6 anyway).  I don't have an
explanation for that.  The idea makes sense: treat a partial page as
'in play' until completely full, then deactivate it.

-- 
Daniel
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/

References:
- [PATCH] drop-behind fix for generic_file_write
  - From: Rik van Riel <riel@conectiva.com.br>
- [PATCH] drop-behind fix for generic_file_write
  - From: Rik van Riel <riel@conectiva.com.br>

Prev by Date: Re: [PATCH] drop-behind fix for generic_file_write
Next by Date: Re: [PATCH] add PF_MEMALLOC to __alloc_pages()
Prev by thread: Re: [PATCH] drop-behind fix for generic_file_write
Next by thread: [PATCH] add PF_MEMALLOC to __alloc_pages()
Index(es):
- Date
- Thread