[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: pte_pagenr/MAP_NR deleted in pre6
- To: Kanoj Sarcar <kanoj@google.engr.sgi.com>
- Subject: Re: pte_pagenr/MAP_NR deleted in pre6
- From: "Stephen C. Tweedie" <sct@redhat.com>
- Date: Thu, 17 Aug 2000 10:11:21 +0100
- Cc: "Stephen C. Tweedie" <sct@redhat.com>, Roman Zippel <roman@augan.com>, linux-mm@kvack.org, linux-kernel@vger.rutgers.edu, rmk@arm.linux.org.uk, nico@cam.org, davem@redhat.com, davidm@hpl.hp.com, alan@lxorguk.ukuu.org.uk
- In-Reply-To: <200008162222.PAA95137@google.engr.sgi.com>; from kanoj@google.engr.sgi.com on Wed, Aug 16, 2000 at 03:22:07PM -0700
- References: <20000816192012.K19260@redhat.com> <200008162222.PAA95137@google.engr.sgi.com>
- Sender: owner-linux-mm@kvack.org
- User-Agent: Mutt/1.2i
Hi,
On Wed, Aug 16, 2000 at 03:22:07PM -0700, Kanoj Sarcar wrote:
> > It's part of what is necessary if we want to push kiobufs into the
> > driver layers. page_to_pfn is needed to for PAE36 support so that
> > PCI64 or dual-address-cycle drivers can handle physical addresses
> > longer than 32 bits long.
>
> While we are on this topic, something like
>
> #define page_to_phys(page) \
> ((((page)-(page)->zone->zone_mem_map) << PAGE_SHIFT) \
> + ((page)->zone->zone_start_paddr))
>
> should work on all platforms on 2.4. (You might have to add in an
> unsigned long long somewhere in there for PAE36).
The long long is exactly what we need to avoid: PAE36 still has
pointers as 32-bit values. Only ptes get the 64-bit treatment.
Adding a BUG() test to detect illegal accesses to >4GB pages on PAE36
would be fine. If we have the appropriate bounce buffer support in
place in pci_dma or wherever suits it, then by the time a driver is
doing page_to_phys() it should already have created the appropriate
bounce buffers and so the BUG() test is fine.
For DAC/PCI64 drivers, though, we need a separate macro like
page_to_pfn so that we can identify the physical address via a 32-bit
value. The driver can then shift that into a 64-bit long long if it
wants to --- there's no need to introduce new 64-bit macros into the
mm just for this special case.
Cheers,
Stephen
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/