[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] pre7-1 semicolon & nicely readableB

To: riel@nl.linux.org
Subject: Re: [PATCH] pre7-1 semicolon & nicely readableB
From: Chris Evans <chris@ferret.lmh.ox.ac.uk>
Date: Tue, 2 May 2000 11:54:19 +0100 (BST)
cc: Roel van der Goot <roel@cs.ualberta.ca>, linux-mm@kvack.org, linux-kernel@vger.rutgers.edu
In-Reply-To: <Pine.LNX.4.21.0005012222540.7508-100000@duckman.conectiva>
Sender: owner-linux-mm@kvack.org

On Mon, 1 May 2000, Rik van Riel wrote:

> I want to inform you that you're wrong. The only difference is
> in readability.

[..]

> In fact, the <10 test is only there to prevent infinite looping
> for when a process with 0 swap_cnt "slips through" the tests above.

If such a value should never "slip through", then, for readability, you
want an assert (e.g. BUG() ).

Chris

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/

Follow-Ups:
- Re: [PATCH] pre7-1 semicolon & nicely readableB
  - From: Rik van Riel <riel@conectiva.com.br>

References:
- Re: [PATCH] pre7-1 semicolon & nicely readableB
  - From: Rik van Riel <riel@conectiva.com.br>

Prev by Date: Re: kswapd @ 60-80% CPU during heavy HD i/o.
Next by Date: Re: [PATCH] pre7-1 semicolon & nicely readableB
Prev by thread: Re: [PATCH] pre7-1 semicolon & nicely readable
Next by thread: Re: [PATCH] pre7-1 semicolon & nicely readableB
Index(es):
- Date
- Thread