Re: [2.2.12 PATCH] Re: bdflush defaults bugreport

["Stephen C. Tweedie" <sct@redhat.com>]

Hi,

On Sun, 5 Sep 1999 04:55:41 -0400 (EDT), "Benjamin C.R. LaHaise"
<blah@kvack.org> said:

> I don't quite think that changing the percentage dirty is the right thing
> in this case.  Rather, the semantics of refile_buffer / wakeup_bdflush /
> mark_buffer_clean need to be tweaked: as it stands, bdflush will wake
> bdflush_done before the percentage of dirty buffers drops below the
> threshhold.  The right fix should be to move the wake_up into the if
> checking the threshhold right below it as the only user of bdflush_done is
> from wake_bdflush when too many buffers are dirty.  Patch below (albeit
> untested).  Alan/Stephen: comments?

It shouldn't have any noticeable effect: all that would happen with that
patch applied is that the woken process would wake early, write one more
buffer and drop straight back into the wakeup_bdflush(1) stall.

--Stephen
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://humbolt.geo.uu.nl/Linux-MM/