Re: filecache/swapcache questions [RFC] [RFT] [PATCH] kanoj-mm12-2.3.8Fix swapoff races

[Andrea Arcangeli <andrea@suse.de>]

On Tue, 29 Jun 1999, Andrea Arcangeli wrote:

For the record: the snapshot wasn't SMP safe.

> 	/*
>+	 * We can release the big kernel lock here since
>+	 * kswapd will see the page locked. -Andrea
>+	 */
>+	unlock_kernel();

This was a bit too early (pefectly ok for kswapd but not ok for the swap
cache SMP safety). We must first take over the swap cache and run
swap_count before be allowed to release the big kernel lock. So this
should be moved a bit lower...

Andrea

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://humbolt.geo.uu.nl/Linux-MM/