[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] depricate ZMAGIC binaries

On 23 May 1999, Eric W. Biederman wrote:

>diff -uNrX linux-ignore-files linux-2.3.3.eb1/mm/filemap.c linux-2.3.3.eb2/mm/filemap.c
>--- linux-2.3.3.eb1/mm/filemap.c	Tue May 18 01:11:52 1999
>+++ linux-2.3.3.eb2/mm/filemap.c	Tue May 18 01:12:47 1999
>@@ -1319,8 +1319,7 @@
> 			return -EINVAL;
> 	} else {
> 		ops = &file_private_mmap;
>-		if (inode->i_op && inode->i_op->bmap &&
>-		    (vma->vm_offset & (inode->i_sb->s_blocksize - 1)))
>+		if (vma->vm_offset & (PAGE_SIZE -1))
> 			return -EINVAL;

Minor issue: since now there is no difference in the align check between
VM_SHARED and VM_PRIVATE you can check the alignment in a common path.

Andrea Arcangeli

--
To unsubscribe, send a message with 'unsubscribe linux-mm my@address'
in the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://humbolt.geo.uu.nl/Linux-MM/