Re: 2.1.91pre2 death by swapping.

[Rik van Riel <H.H.vanRiel@fys.ruu.nl>]

On Thu, 26 Mar 1998, Dr. Werner Fink wrote:

> I've found the following piece of code in the 2.1.91pre2:
> 
> +			/* Refuse to swap out all buffer pages */
> +			if ((buffermem >> PAGE_SHIFT) * 100 > (buffer_mem.min_percent * num_physpages))
> +				goto next;
> 
> IMHO the `>' should be a `<', shouldn't it?

Yes, it should.

> .... and the better place fur such a statement is IMHO
> linux/mm/vmscan.c:do_try_to_free_page() which would avoid the shrink_mmap()
> and its do-while-loop.

shrink_mmap() also shrinks page-cache pages, so it needs
to be called. (unless someone changed the pagecache
semantics too :)

Rik.
+-------------------------------------------+--------------------------+
| Linux: - LinuxHQ MM-patches page          | Scouting       webmaster |
|        - kswapd ask-him & complain-to guy | Vries    cubscout leader |
|     http://www.fys.ruu.nl/~riel/          | <H.H.vanRiel@fys.ruu.nl> |
+-------------------------------------------+--------------------------+