[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [uPATCH] small kswapd improvement ???



On Wed, 4 Mar 1998, Stephen C. Tweedie wrote:

> Regarding the tsk->swap_address stuff: swap_out_pmd() includes the line
> 
> 		tsk->swap_address = address + PAGE_SIZE;

Indeed, the tsk->swap_address = 0 might fit better in
swap_out(), and added to the switch statement at the
bottem, in the 0 case to be exact.

> One other observation while looking at this code: we currently walk over
> every process when swapping, and this is wrong.  We should only walk
> over each mm_struct once.  Another one for the list for 2.2.

Maybe we could give a run a serial number, and add that
number to the struct vma_struct. The serial number should
be updated each time we do the AGE_CLUSTER_SIZE thingy
because we ran out of processes with p->swap_cnt > 0.

Rik.
+-----------------------------+------------------------------+
| For Linux mm-patches, go to | "I'm busy managing memory.." |
| my homepage (via LinuxHQ).  | H.H.vanRiel@fys.ruu.nl       |
| ...submissions welcome...   | http://www.fys.ruu.nl/~riel/ |
+-----------------------------+------------------------------+