[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] Fix paramater/parameter typo in dmesg and source comments

On Sat, 4 Apr 2009, Martin Olsson wrote:

> Robert P. J. Day wrote:
> > drivers/net/wireless/rndis_wlan.c:	devdbg(dev, "setting rndis config
> > paramater failed, %d.", ret);
> >
> > might be worth making another pass.  and while you're at it, you
> > might grep for what i've noticed is a *very* common misspelling:
> > "paramter".  i'm betting you'll find at least a few of those.
>
> I've covered all instances found by grep already except one but that
> one was inside a changelog and I didn't want to change that
> retrospectively. I split them up into one patch for all source
> comment changes and another patch for the debug print outs to dmesg
> etc.
>
> The one you mention here is already covered by the debug print patch.

  ah, i hadn't noticed that earlier patch, sorry.

> As you suspected, paramter is even more common in the kernel dev
> vocabulary :) I might do the some more patches later if the first
> ones are well received / pushed.

  in cases where there are a combination of typoes in both innocuous
comments and actual code (debug msgs, for example), it might be worth
making those corrections in two passes:

  1) harmless fixes in things like comments can go to trivial@xxxxxxxxxx

  2) non-trivial fixes to janitors list

or maybe that's overkill.  it's even possible that, with that many
fixes, you correct stuff on a subsystem-by-subsystem basis to keep the
patch sizes manageable and, for each patch, CC the subsystem list.

rday
--

========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
    Have classroom, will lecture.

http://crashcourse.ca                          Waterloo, Ontario, CANADA
========================================================================

--
To unsubscribe from this list: send an email with
"unsubscribe kernelnewbies" to ecartis@xxxxxxxxxxxx
Please read the FAQ at http://kernelnewbies.org/FAQ