Re: Checking of NULL with __GFP_NOFAIL in kzalloc()

[Sandeep K Sinha <sandeepksinha@xxxxxxxxx>]

On Sun, Mar 1, 2009 at 2:09 PM, Manish Katiyar <mkatiyar@xxxxxxxxx> wrote:
> Hi,
>
> While going through jbd code, I was wondering why do we need to check
> new_transaction for NULL, if we are passing __GFP_NOFAIL ?
> Last code change around this code was when Ted converted kmalloc to
> kzalloc, but since he also didn't remove it I am guessing there would
> be some good reason for it. Can someone enlighten me ?
>
> start_this_handle() {
> ..........
>        ..........
>        new_transaction = kzalloc(sizeof(*new_transaction),
>                        GFP_NOFS|__GFP_NOFAIL);
>        if (!new_transaction) {
>                ret = -ENOMEM;
>                goto out;
>        }
>        ..........
> }
>
True.
I agree. What if (*new_transaction) is zero ???


>
> Thanks -
> Manish
>
> --
> To unsubscribe from this list: send an email with
> "unsubscribe kernelnewbies" to ecartis@xxxxxxxxxxxx
> Please read the FAQ at http://kernelnewbies.org/FAQ
>
>



-- 
Regards,
Sandeep.





 	
“To learn is to change. Education is a process that changes the learner.”

--
To unsubscribe from this list: send an email with
"unsubscribe kernelnewbies" to ecartis@xxxxxxxxxxxx
Please read the FAQ at http://kernelnewbies.org/FAQ