[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: amateur query in Uniform cdrom device driver



On Mon, Aug 01, 2005 at 12:39:27 +0530, Raseel Bhagat wrote:
> >And for reference, here's the #define:
> >
> >#define ENSURE(call, bits) if (cdo->call == NULL) *change_capability &= 
> >~(bits)
> > 
> >
> Hi ,
>    I did read the comment, but I was confused because  the 
> 'change_capability' variable is not reassigned to 'cdo->capability'.
> What I mean is , once ENSURE is executed, shouldn't the next step be
>  cdo->capabilty = *change_capability;
> And anyways, the CDROM_CAN macro is used for masking the cdo->capability 
> everywhere else in the code.

Noticed change_capability is a pointer? It can be that
change_capability = &cdo->capability, which it really is and is this way
because then cdo can be const and the assignment can get rid of it
without compiler complaining (with explicit cast).

-------------------------------------------------------------------------------
						 Jan 'Bulb' Hudec <bulb@xxxxxx>

Attachment: signature.asc
Description: Digital signature