Re: Gotos

[Muli Ben-Yehuda <mulix@xxxxxxxxx>]

On Thu, Jan 08, 2004 at 02:30:06PM +0100, Tim Cambrant wrote:
> Could someone please explain to me why we have a bunch
> of gotos where they really could be removed? I'm sure
> there is a good reason, but I simply don't see it. For
> example, why shouldn't the following patch be applied?
> I'd appreciate any explanation I could get. Thank you.

In this case, I agree that the patch could be applied. However,
there's a school of thought that goes something like this

- we might add locking or some other resource acquisition to this
function in the future
- when we do, it would have to be converted to this 'goto style' to
clean up properly
- therefore, just use the goto style from the beginning, for
consistency

And I agree with that school of thought as well. It boils down to the
style of whoever wrote the code. 

Cheers, 
Muli 
-- 
Muli Ben-Yehuda
http://www.mulix.org | http://mulix.livejournal.com/

"the nucleus of linux oscillates my world" - gccbot@#offtopic

Digital signature