Re: Error in usb_control_msg Documentation

[Greg KH <greg@kroah.com>]

On Thu, May 09, 2002 at 10:24:52AM -0400, Chris BeHanna wrote:
> On Wed, 8 May 2002, Greg KH wrote:
> 
> > On Wed, May 08, 2002 at 10:23:03PM -0400, Chris BeHanna wrote:
> > > The generated documentation in your Kernel API section contains a
> > > grievous error:  the return values for usb_control_msg() are listed as
> > > negative for error, 0 for success.  This is not correct:  a successful
> > > return for usb_control_msg() will result in a nonnegative integer
> > > indicating the actual number of bytes sent or received in the "data"
> > > parameter.
> > >
> > > Please fix this ASAP.  This mistake cost me a lot of time, and I'd hate
> > > to see others hamstrung by it.
> >
> > So kind of you to send a patch :)
> 
>     If I knew to whom to send a patch, I could send one.  You were my
> first point of contact (and it was late, and my coffee cup was long
> since empty, and <insert excuse here>).

Out of any email address out there, kernelnewbies@nl.linux.org does not
show up in the MAINTAINERS file, or any of the drivers/usb/* files.
Please take a look at Documentation/SubmittingPatches next time for how
to figure out who to send such things to next time :)

> > Also, if you look in 2.5, this is already fixed.
> 
>     2.5 is not a production kernel.  Besides, this needs to be fixed
> in 2.4, which, I surmise, has at least a few more months of life
> before anything resembling 2.6 becomes available.

True, but a lot of the USB changes in 2.5 are about to be backported to
2.4, once 2.4.19-final happens, including a big documentation update.
If someone was so inclined, I would be glad to take a patch for this fix
right now though.

> > Might I ask what kind of USB driver you wrote?
> 
>     I'm writing a driver for a two-sided checkscanner.  It's not quite
> ready for prime time.

Nice, what kind of userspace interface does it use (usb-serial,
character device, etc.)?

thanks,

greg k-h
--
Kernelnewbies: Help each other learn about the Linux kernel.
Archive:       http://mail.nl.linux.org/kernelnewbies/
FAQ:           http://kernelnewbies.org/faq/