Re: Error in usb_control_msg Documentation

[Chris BeHanna <behanna@zbzoom.net>]

On Wed, 8 May 2002, Greg KH wrote:

> On Wed, May 08, 2002 at 10:23:03PM -0400, Chris BeHanna wrote:
> > The generated documentation in your Kernel API section contains a
> > grievous error:  the return values for usb_control_msg() are listed as
> > negative for error, 0 for success.  This is not correct:  a successful
> > return for usb_control_msg() will result in a nonnegative integer
> > indicating the actual number of bytes sent or received in the "data"
> > parameter.
> >
> > Please fix this ASAP.  This mistake cost me a lot of time, and I'd hate
> > to see others hamstrung by it.
>
> So kind of you to send a patch :)

    If I knew to whom to send a patch, I could send one.  You were my
first point of contact (and it was late, and my coffee cup was long
since empty, and <insert excuse here>).

> Also, if you look in 2.5, this is already fixed.

    2.5 is not a production kernel.  Besides, this needs to be fixed
in 2.4, which, I surmise, has at least a few more months of life
before anything resembling 2.6 becomes available.

> Might I ask what kind of USB driver you wrote?

    I'm writing a driver for a two-sided checkscanner.  It's not quite
ready for prime time.

-- 
Chris BeHanna
Software Engineer                   (Remove "bogus" before responding.)
behanna@bogus.zbzoom.net
                   Turning coffee into software since 1990.

--
Kernelnewbies: Help each other learn about the Linux kernel.
Archive:       http://mail.nl.linux.org/kernelnewbies/
FAQ:           http://kernelnewbies.org/faq/